fix(website): code review fixes — responsive grid, unique IDs, iframe sandbox, design tokens#103
Merged
Merged
Conversation
…me sandbox, design tokens 1. FeaturesGrid: minmax(440px) → minmax(min(440px, 100%)) for mobile 2. WhitePaperGate: unique IDs per library (angular-, render-, chat-) 3. Iframes: add sandbox="allow-scripts allow-same-origin" 4. Design tokens: add renderGreen (#1a7a40) and chatPurple (#5a00c8), replace all hardcoded color values across 15 component files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 4 important issues from code review:
minmax(440px)→minmax(min(440px, 100%))prevents horizontal overflow on mobile screens < 440pxangular-whitepaper-gate,render-whitepaper-gate,chat-whitepaper-gate)sandbox="allow-scripts allow-same-origin"for defense-in-depthrenderGreenandchatPurpleto@cacheplane/design-tokens, replaced all hardcoded#1a7a40and#5a00c8values across 15 component files17 files changed across 3 landing page component sets + LibrariesSection + design tokens.
Test plan
nx build website— successnx lint website— 0 errors, 0 warnings🤖 Generated with Claude Code